Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipld: move from DAGService to BlockService #730

Merged
merged 4 commits into from
May 30, 2022
Merged

ipld: move from DAGService to BlockService #730

merged 4 commits into from
May 30, 2022

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented May 19, 2022 •
edited
Loading

No description provided.

@vgonkivs vgonkivs force-pushed the remove_ipld_dependecies branch from fe0268a to 5baee2b Compare May 23, 2022 09:20
@vgonkivs vgonkivs force-pushed the remove_ipld_dependecies branch from 5baee2b to 82530f9 Compare May 23, 2022 15:48
@vgonkivs vgonkivs marked this pull request as ready for review May 23, 2022 16:07
@vgonkivs vgonkivs self-assigned this May 23, 2022
adlerjohn
adlerjohn reviewed May 24, 2022
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comments

@vgonkivs vgonkivs force-pushed the remove_ipld_dependecies branch from 82530f9 to d691e95 Compare May 24, 2022 17:50
liamsi
liamsi approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @Wondertan should have a final say here but this LGTM.

Wondertan
Wondertan approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you.
Just a few prettifying nits.

Also, this PR does not fully solve the attached issue. It is just a first step.

ipld/retriever.go Outdated Show resolved Hide resolved
ipld/plugin/nmt.go Outdated Show resolved Hide resolved
@Wondertan
Copy link
Member

Needs rebase to fix tests

@vgonkivs vgonkivs force-pushed the remove_ipld_dependecies branch from d691e95 to aa82d55 Compare May 30, 2022 13:08
@codecov-commenter
Copy link

Codecov Report

Merging #730 (aa82d55) into main (55b7b7e) will decrease coverage by 0.01%.
The diff coverage is 98.91%.

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   52.77%   52.76%   -0.02%     
==========================================
  Files         116      116              
  Lines        6596     6603       +7     
==========================================
+ Hits         3481     3484       +3     
- Misses       2752     2755       +3     
- Partials      363      364       +1
Impacted Files Coverage Δ
header/header.go 46.77% <0.00%> (ø)
node/node.go 62.50% <ø> (ø)
header/core/exchange.go 50.00% <100.00%> (ø)
header/core/listener.go 58.49% <100.00%> (ø)
ipld/add.go 82.35% <100.00%> (ø)
ipld/get.go 77.14% <100.00%> (ø)
ipld/get_shares.go 73.46% <100.00%> (ø)
ipld/nmt_adder.go 63.33% <100.00%> (-3.34%) ⬇️
ipld/plugin/nmt.go 35.88% <100.00%> (+1.05%) ⬆️
ipld/retriever.go 90.10% <100.00%> (+0.45%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b7b7e...aa82d55. Read the comment docs.

renaynay
renaynay approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one comment

node/p2p/ipld.go Show resolved Hide resolved
@vgonkivs vgonkivs merged commit 1c45a66 into celestiaorg:main May 30, 2022
This was referenced Jun 7, 2022
Closed
Merged
@vgonkivs vgonkivs deleted the remove_ipld_dependecies branch June 20, 2022 13:51
@Wondertan Wondertan changed the title ipld: move for dag service to block service ipld: move from dag service to block service Jul 3, 2022
@Wondertan Wondertan changed the title ipld: move from dag service to block service ipld: move from DAGService to BlockService Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@liamsi liamsi liamsi approved these changes

Assignees

@vgonkivs vgonkivs

Labels
area:ipld IPLD plugin
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vgonkivs @Wondertan @codecov-commenter @adlerjohn @liamsi @renaynay